AI/myAi
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Database architecture consolidation: repository ownership and naming consistency #34

Closed
gelu wants to merge 0 commits from main into staging
pull from: main
merge into: AI:staging
Conversation 0 Commits - Files Changed -
gelu commented 2026-05-29 06:51:43 +00:00
Owner
Copy Link
Copy Source

Summary

Complete refactoring of the data layer architecture to consolidate repository ownership and enforce consistent naming conventions across all data projects.

Changes

  1. Repository consolidation: Moved all data repositories from API projects to their corresponding data projects

    • RAG repository → rag-data
    • CV Matcher repositories → cv-matcher-data
    • Email repository → email-data (new project)

  2. Schema naming consistency: Updated all schema names to use lowercase naming

  3. Migration constants: Created MigrationConstants.cs in each data project to eliminate hardcoded strings in migrations

  4. Email data layer: Created new email-data project with DbContext, repository, service, and migrations

  5. Project naming convention: Renamed mail-api-data → mail-data for consistency

  6. Cleanup: Removed duplicate Data folders from models projects

Test plan

  • ✓ dotnet build myAi.sln — 0 errors, 0 warnings
  • Spin up Docker containers and verify database migrations
  • Manual testing: Email delivery to user and operator addresses
  • Manual testing: Database updates apply without restart

🤖 Generated with Claude Code

## Summary Complete refactoring of the data layer architecture to consolidate repository ownership and enforce consistent naming conventions across all data projects. ### Changes 1. **Repository consolidation**: Moved all data repositories from API projects to their corresponding data projects - RAG repository → rag-data - CV Matcher repositories → cv-matcher-data - Email repository → email-data (new project) 2. **Schema naming consistency**: Updated all schema names to use lowercase naming 3. **Migration constants**: Created MigrationConstants.cs in each data project to eliminate hardcoded strings in migrations 4. **Email data layer**: Created new email-data project with DbContext, repository, service, and migrations 5. **Project naming convention**: Renamed mail-api-data → mail-data for consistency 6. **Cleanup**: Removed duplicate Data folders from models projects ## Test plan - ✓ dotnet build myAi.sln — 0 errors, 0 warnings - [ ] Spin up Docker containers and verify database migrations - [ ] Manual testing: Email delivery to user and operator addresses - [ ] Manual testing: Database updates apply without restart 🤖 Generated with [Claude Code](https://claude.com/claude-code)
gelu added 5 commits 2026-05-29 06:51:43 +00:00
Move RAG repository from rag-api to rag-data — consolidate data layer ownership 487924e345 
- Move IRagRepository, EfRagRepository, and VectorSerializer from rag-api/Data to rag-data/Repositories
- Add rag-api-models ProjectReference to rag-data.csproj for model type availability
- Delete rag-api/Data folder (no longer needed; all data access is now in rag-data)
- This aligns RAG with email-api and other services: all data code in the data project

Pattern: rag-api (API logic) → rag-data (repository, EF entities, migrations)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Rename email schema from 'emailApi' to 'email' — consistent naming convention 707f547014 
- Update MigrationConstants.SchemaName in email-api-data from 'emailApi' to 'email'
- All migrations automatically use the new schema name via MigrationConstants reference
- Aligns with naming convention: 'email', 'rag', 'cvMatcher', 'cvSearch', 'myAi'

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Move CV matcher repositories from cv-matcher-api to cv-matcher-data 43017036fd 
- Move IAiPromptsRepository, EfAiPromptsRepository to cv-matcher-data/Repositories
- Move IMatcherRepository, EfMatcherRepository to cv-matcher-data/Repositories
- Add cv-matcher-api-models ProjectReference to cv-matcher-data.csproj
- Delete cv-matcher-api/Data folder (all data access now in cv-matcher-data)

Pattern: cv-matcher-api (logic) → cv-matcher-data (repositories, EF entities, migrations)
Aligns with rag-api → rag-data consolidation

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Remove duplicate Data folders from models projects 33d92551da 
- Delete cv-search-models/Data (duplicate of cv-search-data/Data)
- Delete myai-models/Data (duplicate of myai-data/Data)
- DbContext and Entities belong only in -data projects, not -models

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
refactor(data): rename email-api-data to email-data for consistent naming ea9bc87981 
- Rename project folder Apis/email-api-data → Apis/email-data
- Rename csproj file: email-api-data.csproj → email-data.csproj
- Update csproj properties: AssemblyName and RootNamespace (email-data, Email.Data)
- Update C# namespaces: EmailApi.Data → Email.Data across all email-data files
- Update project references in api.csproj and email-api.csproj
- Update migration assembly references in api/Program.cs and email-api/Program.cs
- Update cv-search-job references to use email-data project and Email.Data namespace
- Update solution file to reference new email-data project path
- Remove hardcoded schema name from SmtpEmailDispatcher, use template service instead

This maintains consistency with other data project naming convention (no service-type suffix).
All tests passing, build succeeds.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
gelu added 3 commits 2026-05-29 07:18:19 +00:00
fix(docker): update Dockerfile references from email-api-data to email-data 2b43ec5984 
Update all Dockerfile COPY commands to reference the renamed email-data project
instead of email-api-data. This resolves Docker build failures introduced by the
email-api-data → email-data rename.

- Apis/api/Dockerfile: Update lines 8 and 20
- Apis/email-api/Dockerfile: Update lines 6 and 17
- Jobs/cv-search-job/Dockerfile: Update lines 10 and 23

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
fix(email-data): update migration files to use MigrationConstants.SchemaName 181a0b23b5 
Fix schema name references in migration Designer.cs and ModelSnapshot files.
Previously these files contained hardcoded 'emailApi' schema name instead of
using MigrationConstants.SchemaName constant. This was causing EF Core to
detect pending model changes and fail migrations.

Changes:
- 20260528100000_CreateEmailTemplates.Designer.cs: Use MigrationConstants.SchemaName
- 20260528130652_SeedEmailTemplates.Designer.cs: Use MigrationConstants.SchemaName
- EmailApiDbContextModelSnapshot.cs: Use MigrationConstants.SchemaName and updated namespace

Also updated entity namespace references from EmailApi.Data to Email.Data.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
refactor(migrations): extract schema constant for clarity
Build and Push Docker Images Staging / build (push) Successful in 8m22s
Details
e14a6a0f69
gelu closed this pull request 2026-05-29 07:19:16 +00:00
Some checks are pending
Build and Push Docker Images Staging / build (push) Successful in 8m22s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude gelu
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: AI/myAi#34
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?