chore: upgrade jQuery from 3.6.1 to 4.0.0, fix misnamed vendor file #30

2026-05-28T06:58:25Z

gelu commented

2026-05-28 06:58:25 +00:00

What

Upgrade jQuery from 3.6.1 to 4.0.0 and fix the misnamed vendor file.

Why

The vendor file was named jquery-1.12.4.min.js but actually contained jQuery 3.6.1 — misleading and easy to overlook. jQuery 4.0.0 is the current stable release. The file size actually decreased slightly (89 KB → 78 KB).

Changes

Added web/wwwroot/js/vendor/jquery-4.0.0.min.js (jQuery 4.0.0, correctly named)
Removed web/wwwroot/js/vendor/jquery-1.12.4.min.js (was actually 3.6.1, now gone)
Updated <script> reference in both index.html and cv-matcher/index.html

Compatibility check

None of the removed jQuery 4.0 APIs are used in main.js:

No $.isArray, $.isFunction, $.isNumeric, $.trim, $.type, $.parseJSON, $.now, $.nodeName
All APIs in active use ($.ajax, $.when, $.get, $.getJSON, .done()/.fail()/.always(), .on(), .prop(), .val(), .css(), .addClass(), .removeClass(), .toggleClass(), .is(), .each()) remain available in the full 4.0 build

Testing

dotnet build web/web.csproj — 0 errors, 0 warnings
Manual: both pages load; language switch, contact form, CV matcher form all functional

Risk Assessment

Breaking changes? No — compatibility verified against jQuery 4.0 migration guide
Performance impact: minor improvement (89 KB → 78 KB)

Checklist

All tests passing
Code review ready
No merge conflicts

## What Upgrade jQuery from 3.6.1 to 4.0.0 and fix the misnamed vendor file. ## Why The vendor file was named `jquery-1.12.4.min.js` but actually contained jQuery 3.6.1 — misleading and easy to overlook. jQuery 4.0.0 is the current stable release. The file size actually decreased slightly (89 KB → 78 KB). ## Changes - Added `web/wwwroot/js/vendor/jquery-4.0.0.min.js` (jQuery 4.0.0, correctly named) - Removed `web/wwwroot/js/vendor/jquery-1.12.4.min.js` (was actually 3.6.1, now gone) - Updated `<script>` reference in both `index.html` and `cv-matcher/index.html` ## Compatibility check None of the removed jQuery 4.0 APIs are used in `main.js`: - No `$.isArray`, `$.isFunction`, `$.isNumeric`, `$.trim`, `$.type`, `$.parseJSON`, `$.now`, `$.nodeName` - All APIs in active use (`$.ajax`, `$.when`, `$.get`, `$.getJSON`, `.done()/.fail()/.always()`, `.on()`, `.prop()`, `.val()`, `.css()`, `.addClass()`, `.removeClass()`, `.toggleClass()`, `.is()`, `.each()`) remain available in the full 4.0 build ## Testing - `dotnet build web/web.csproj` — 0 errors, 0 warnings - Manual: both pages load; language switch, contact form, CV matcher form all functional ## Risk Assessment - Breaking changes? No — compatibility verified against jQuery 4.0 migration guide - Performance impact: minor improvement (89 KB → 78 KB) ## Checklist - [x] All tests passing - [x] Code review ready - [x] No merge conflicts

gelu added 1 commit 2026-05-28 06:58:25 +00:00

chore: upgrade jQuery from 3.6.1 to 4.0.0 9b0d7fb907

The vendor file was misnamed jquery-1.12.4.min.js but contained v3.6.1.
Replaced with the correctly-named jquery-4.0.0.min.js (78 KB, up from 89 KB).

Compatibility check: none of the removed jQuery 4.0 APIs are used in
main.js — no $.isArray, $.isFunction, $.trim, $.type, $.parseJSON, etc.
All ajax/deferred/DOM methods in use ($.ajax, $.when, .done/.fail/.always,
.on, .prop, .css, .addClass etc.) remain in the full 4.0 build.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude approved these changes 2026-05-28 10:36:55 +00:00

gelu merged commit bf29478207 into main

2026-05-28 10:39:33 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: AI/myAi#30